[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/6] target-arm queue
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PULL 0/6] target-arm queue |
Date: |
Thu, 31 Oct 2013 15:39:56 +0100 |
On Thu, Oct 31, 2013 at 3:36 PM, Andreas Färber <address@hidden> wrote:
> Am 31.10.2013 15:31, schrieb Peter Maydell:
>> On 31 October 2013 14:18, Andreas Färber <address@hidden> wrote:
>>> Peter, since I had picked up the first two patches into my still pending
>>> qom-next pull, as per the QEMU Summit discussion those patches should've
>>> gotten an Acked-by.
>>
>> Hmm? I don't recall this part of the discussion. If you want the
>> patches to have an Acked-by from you you need to send mail
>> to the list with an Acked-by line.
>
> No, I added a Signed-off-by. It was clearly stated that a Reviewed-by
> needs to be explicitly sent as reply but that "looks okay" should in
> exactly such a case where sender=submaintainer should be recorded as
> Acked-by, and Sob is certainly stronger than Acked-by. Cf. minutes.
Nope. If you want there to be an Acked-by, say "Acked-by:". Don't
make people infer your Acked-bys.
And adding tags is a nice-to-have. There is no "rule" stating that
you must include everyone that appears on the mailing list. But I
expect that maintainers try to
Regards,
Anthony Liguori
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
>
- [Qemu-devel] [PULL 2/6] hw/arm: Tidy up conditional calls to arm_load_kernel, (continued)
- [Qemu-devel] [PULL 2/6] hw/arm: Tidy up conditional calls to arm_load_kernel, Peter Maydell, 2013/10/25
- [Qemu-devel] [PULL 4/6] target-arm: sort TCG cpreg list by KVM-style 64 bit ID number, Peter Maydell, 2013/10/25
- [Qemu-devel] [PULL 1/6] hw/arm/boot: Make user not specifying a kernel not an error, Peter Maydell, 2013/10/25
- [Qemu-devel] [PULL 6/6] integrator: fix Linux boot failure by emulating dbg region, Peter Maydell, 2013/10/25
- [Qemu-devel] [PULL 3/6] target-arm: Add CP15 VBAR support, Peter Maydell, 2013/10/25
- Re: [Qemu-devel] [PULL 0/6] target-arm queue, Edgar E. Iglesias, 2013/10/31
- Re: [Qemu-devel] [PULL 0/6] target-arm queue, Andreas Färber, 2013/10/31
- Re: [Qemu-devel] [PULL 0/6] target-arm queue, Anthony Liguori, 2013/10/31
- Re: [Qemu-devel] [PULL 0/6] target-arm queue, Peter Maydell, 2013/10/31
- Re: [Qemu-devel] [PULL 0/6] target-arm queue, Andreas Färber, 2013/10/31
- Re: [Qemu-devel] [PULL 0/6] target-arm queue,
Anthony Liguori <=
- Re: [Qemu-devel] [PULL 0/6] target-arm queue, Andreas Färber, 2013/10/31
- Re: [Qemu-devel] [PULL 0/6] target-arm queue, Anthony Liguori, 2013/10/31
- Re: [Qemu-devel] [PULL 0/6] target-arm queue, Anthony Liguori, 2013/10/31
- Re: [Qemu-devel] [PULL 0/6] target-arm queue, Andreas Färber, 2013/10/31
- Re: [Qemu-devel] [PULL 0/6] target-arm queue, Anthony Liguori, 2013/10/31
- Re: [Qemu-devel] [PULL 0/6] target-arm queue, Andreas Färber, 2013/10/31
- Re: [Qemu-devel] [PULL 0/6] target-arm queue, Peter Maydell, 2013/10/31
- Re: [Qemu-devel] [PULL 0/6] target-arm queue, Peter Maydell, 2013/10/31
- Re: [Qemu-devel] [PULL 0/6] target-arm queue, Anthony Liguori, 2013/10/31
- Re: [Qemu-devel] [PULL 0/6] target-arm queue, Peter Maydell, 2013/10/31