Re: [Qemu-devel] [PULL v2 00/56] QOM devices patch queue 2013-10-31

[Andreas Färber]

Anthony,

Am 31.10.2013 22:03, schrieb Anthony Liguori:
> On Thu, Oct 31, 2013 at 3:37 PM, Andreas Färber <address@hidden> wrote:
>> Hello Anthony,
>>
>> This is my updated QOM devices patch queue. Please pull or provide more 
>> details
>> of what is not working in your build environment.
> 
> Andreas,
> 
> If you cannot be bothered to adequately test your pull requests, then
> don't bother sending them.

You want to be rude? I can be rude, too. Who merged the block pull that
according to the qtests I provided broke several machines? You. Your
testing is not perfect either, so watch your language.

In particular since Friday make check fails on qemu.git:

GTESTER check-qtest-arm
GTESTER check-qtest-i386
main-loop: WARNING: I/O thread spun for 1000 iterations
main-loop: WARNING: I/O thread spun for 1000 iterations
blkdebug: Suspended request 'A'
blkdebug: Resuming request 'A'
main-loop: WARNING: I/O thread spun for 1000 iterations
main-loop: WARNING: I/O thread spun for 1000 iterations
GTESTER check-qtest-mips64el
qemu-system-mips64el: /home/andreas/QEMU/qemu-cpu/exec.c:802:
register_subpage: Assertion `existing->mr->subpage || existing->mr ==
&io_mem_unassigned' failed.
Broken pipe
GTester: last random seed: R02S52ce3c776bf01d96752819c947c85576
qemu-system-mips64el: /home/andreas/QEMU/qemu-cpu/exec.c:802:
register_subpage: Assertion `existing->mr->subpage || existing->mr ==
&io_mem_unassigned' failed.
Broken pipe
GTester: last random seed: R02S65379793c25d23b7d98dc1032139cc63
qemu-system-mips64el: /home/andreas/QEMU/qemu-cpu/exec.c:802:
register_subpage: Assertion `existing->mr->subpage || existing->mr ==
&io_mem_unassigned' failed.
Broken pipe
GTester: last random seed: R02Sa11769e1b4918ba79a24beeb22c829ae
make: *** [check-qtest-mips64el] Fehler 1

git-bisect says this:

a53ae8e934cd54686875b5bcfc2f434244ee55d6 is the first bad commit
commit a53ae8e934cd54686875b5bcfc2f434244ee55d6
Author: Marcel Apfelbaum <address@hidden>
Date:   Mon Sep 16 11:21:16 2013 +0300

    hw/pci: partially handle pci master abort

    A MemoryRegion with negative priority was created and
    it spans over all the pci address space.
    It "intercepts" the accesses to unassigned pci
    address space and will follow the pci spec:
     1. returns -1 on read
     2. does nothing on write

    Note: setting the RECEIVED MASTER ABORT bit in the STATUS register
          of the device that initiated the transaction will be
          implemented in another series

    Signed-off-by: Marcel Apfelbaum <address@hidden>
    Acked-by: Michael S. Tsirkin <address@hidden>
    Signed-off-by: Michael S. Tsirkin <address@hidden>

:040000 040000 b115d38ba08642a56300da49bfe7e3e7148eb20d
b364a5cfb65ffbf4e83cadaa0afeb9922aec331b M      hw
:040000 040000 d0b3d397bb819cdbfd66ca0c199c62bd55f2db9e
263f0822e4d4a078bd772c8a84e113e1c28bbad9 M      include

I.e. the first pull you've merged after Edgar doesn't pass make check!

But worse, my qom-test shows that isapc asserts, too:

GTESTER check-qtest-i386
main-loop: WARNING: I/O thread spun for 1000 iterations
main-loop: WARNING: I/O thread spun for 1000 iterations
blkdebug: Suspended request 'A'
blkdebug: Resuming request 'A'
main-loop: WARNING: I/O thread spun for 1000 iterations
qemu-system-i386: /home/andreas/QEMU/qemu/hw/i386/acpi-build.c:135:
acpi_get_pm_info: Assertion `obj' failed.
Broken pipe
GTester: last random seed: R02Sdbc8da98b2e9405d3ac769aca1780a25
make: *** [check-qtest-i386] Fehler 1

So it would be really good to have those tests in qemu.git and actually
run! You already didn't take them for 1.6 and back then you didn't
report any breakage at all. We only had a discussion about how to handle
lack of arguments, which Aurélien ended by reverting changes to mips and
insisting that missing arguments continue to be errors.

> make check fails spectacularly.  I've confirmed this on multiple
> platforms on different distros.

You have pastebin'ed me a really non-telling snippet. I have already
showed you that on my side (openSUSE 12.3 w/ 3.12 kernel) make check
succeeded just fine, same for v2 or I wouldn't have sent it. You should
know me well enough for that!!!

So it's definitely not me being sloppy but some environmental difference
between our setups. And I have repeatedly asked you on IRC about your
setup without getting further replies. Show me what to fix and I can
look into fixing it.

All I could come up with was some non-fatal audio error messages
depending on QEMU_AUDIO_DRV environment variable. No comparison to the
actual breakages that we are seeing in qemu.git now.

> The errors are the exact same as before.  Install some VMs and
> reproduce the problem.  I just checked and it fails under 64-bit
> Fedora 19.

I have successfully booted up openSUSE 12.3 x86_64 and SLES 11 SP3
x86_64 without any issue. You really need to explain "the problem"!

Regards,
Andreas

> 
> Regards,
> 
> Anthony Liguori
> 
>> v2 is rebased, dropping two ARM patches, and the observed SD segfault had 
>> been
>> fixed in 794cbc26eb94ce13c75d105eea9ff0afff56e2c2.
>> Patches are not manually changed, thus intentionally not resent.
>>
>> Thanks,
>> Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg