Re: [Qemu-devel] [PULL v2 00/56] QOM devices patch queue 2013-10-31

[Andreas Färber]

Anthony,

Am 03.11.2013 14:58, schrieb Anthony Liguori:
> On Sun, Nov 3, 2013 at 5:28 AM, Andreas Färber <address@hidden> wrote:
>> Anthony,
>>
>>> The errors are the exact same as before.  Install some VMs and
>>> reproduce the problem.  I just checked and it fails under 64-bit
>>> Fedora 19.
>>
>> I have successfully booted up openSUSE 12.3 x86_64 and SLES 11 SP3
>> x86_64 without any issue. You really need to explain "the problem"!
> 
> Andreas,
> 
> I told you how to reproduce the problem.

No, you didn't, that's the problem! See below.

>  If you choose not to
> investigate, fine, but don't spam me with resends of a pull request
> with a known breakage.

This is v2 so that's hardly spamming anyone. And may I remind you that
you have not bothered to send even a single email reply to v1.

Here's my IRC excerpt:

Okt 10 18:42:37 <aliguori>      afaerber_, ping
Okt 10 18:44:01 <aliguori>      afaerber_, http://pastie.org/8392810

--8<--
[40d09bdc65bab245439ac85b60e26b90212d5f06] qtest: Prepare QOM machine tests
running ./bisect-qemu-test.sh
~/build/qemu ~/git/qemu
audio: Failed to create voice `lm4549.out'
audio: Failed to create voice `lm4549.out'
audio: Failed to create voice `lm4549.out'
audio: Failed to create voice `lm4549.out'
audio: Failed to create voice `lm4549.out'
audio: Failed to create voice `lm4549.out'
audio: Failed to create voice `lm4549.out'
audio: Failed to create voice `lm4549.out'
audio: Failed to create voice `mm_ac97.in'
audio: Failed to create voice `mm_ac97.out'
40d09bdc65bab245439ac85b60e26b90212d5f06 is the first bad commit
commit 40d09bdc65bab245439ac85b60e26b90212d5f06
Author: Andreas Färber <address@hidden>
Date:   Mon Jul 29 05:44:47 2013 +0200

    qtest: Prepare QOM machine tests

    Instantiate all [*] machines per target, so that they get a bit of test
    coverage at all. This has proven helpful during QOM refactorings.

    [*] ppcemb target contains some non-working non-embedded machines, and
    ppc405 CPUs are not available there either.
    i386 and x86_64 do not cover pc*-x.y or xenfv.

    Signed-off-by: Andreas Färber <address@hidden>

:040000 040000 f2bbe30467a164608ca9d8be20b0d689b607c396
673e5111dc8d23d7c00a76ba6ea613b8c6724235 M      tests
bisect run success
--8<--

Okt 14 18:14:20 <aliguori>      afaerber, ping
Okt 14 18:14:48 <afaerber>      aliguori, pong - I already started writing to
you, my output looks different
Okt 14 18:14:55 <aliguori>      okay, cool
Okt 14 18:15:02 <aliguori>      afaerber, just wanted to make sure you saw my
note
Okt 14 18:15:34 <afaerber>      aliguori, yeah I did but I was away on Friday
and most of the weekend
Okt 14 18:16:02 <afaerber>      aliguori, do you have any QEMU_AUDIO_DRV set
in your environment?
Okt 14 18:16:35 <afaerber>      I usually unset that since openSUSE sets it
to alsa but I usually don't enable alsa support in configure
Okt 14 18:16:37 <aliguori>      afaerber, no
Okt 14 18:20:04 <afaerber>      s/alsa/pulseaudio/g
Okt 14 18:21:37 <afaerber>      aliguori, http://paste.opensuse.org/760f8573
Okt 14 18:22:06 <afaerber>      there is an oss error for lm32 but no test
failures
Okt 14 18:22:24 <afaerber>      similarly as mentioned before if pa driver is
requested but not built in there are errors, too

Okt 15 19:05:03 <afaerber>      aliguori, any new insights into the qtest issue?
Okt 15 19:05:28 *       afaerber has rebased and getting broken pipe now,
re-checking master

(NB the broken pipe after rebasing was the SD block breakage.)

That's all I had from you.

And for me asking you to look into it with me during Hackathon there
will surely be several witnesses from QEMU Summit.

So facts are,

1) You only told me "64-bit Fedora 19" *after* I sent v2. Don't complain
about me doing so then!
2) You neither gave your configure nor your runtime command line, just
some non-telling script output and then didn't reply again until v2. So
no, I couldn't reproduce!
3) Installing a VM should be completely unaffected by my qom-test, which
only affects make check.
4) Not a single test failure of make check or make check V=1 has been
shown by anyone for me to investigate. Is this only about the audio
subsystem spitting some weird non-fatal messages? You didn't mind
Paolo's endianness tests spitting messages which me then cleaned up.
5) qemu.git is badly broken in multiple ways, making it hard to send any
meaningful v3 until you guys have either fixed or reverted your genuine
breakages.

I have downloaded Fedora 19 now and am setting up a VM, but I strongly
doubt that "Install some VMs and reproduce the problem" is going to
provide any better insights on Fedora without additional input...

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg