qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RESEND][PATCH] migration: drop MADVISE_DONT_NEED for i


From: Peter Lieven
Subject: Re: [Qemu-devel] [RESEND][PATCH] migration: drop MADVISE_DONT_NEED for incoming zero pages
Date: Mon, 04 Nov 2013 10:29:25 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0

On 24.10.2013 12:07, Juan Quintela wrote:
Peter Lieven <address@hidden> wrote:
The madvise for zeroed out pages was introduced when every transferred
zero page was memset to zero and thus allocated. Since commit
211ea740 we check for zeroness of a target page before we memset
it to zero. Additionally we memmap target memory so it is essentially
zero initialized (except for e.g. option roms and bios which are loaded
into target memory although they shouldn't).

It was reported recently that this madvise causes a performance degradation
in some situations. As the madvise should only be called rarely and if it's 
called
it is likely on a busy page (it was non-zero and changed to zero during 
migration)
drop it completely.
Reviewed-by: Juan Quintela <address@hidden>

I take it.  I am on KVM Forum/LinuxCon this week.  Will send when back
at home.
Ping

Peter



reply via email to

[Prev in Thread] Current Thread [Next in Thread]