Re: [Qemu-devel] [PATCH v2] block: per caller dirty bitmap

[Fam Zheng]

On 11/04/2013 06:37 PM, Paolo Bonzini wrote:
> Il 04/11/2013 10:30, Fam Zheng ha scritto:
> > diff --git a/include/block/block.h b/include/block/block.h
> > index 3560deb..06f424c 100644
> > --- a/include/block/block.h
> > +++ b/include/block/block.h
> > @@ -388,12 +388,15 @@ void *qemu_blockalign(BlockDriverState *bs, size_t size);
> >   bool bdrv_qiov_is_aligned(BlockDriverState *bs, QEMUIOVector *qiov);
> >   
> >   struct HBitmapIter;
> > -void bdrv_set_dirty_tracking(BlockDriverState *bs, int granularity);
> > -int bdrv_get_dirty(BlockDriverState *bs, int64_t sector);
> > +typedef struct BdrvDirtyBitmap BdrvDirtyBitmap;
> > +BdrvDirtyBitmap *bdrv_create_dirty_bitmap(BlockDriverState *bs, int 
> > granularity);
> > +void bdrv_release_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap *bitmap);
> > +int bdrv_get_dirty(BlockDriverState *bs, BdrvDirtyBitmap *bitmap, int64_t 
> > sector);
> >   void bdrv_set_dirty(BlockDriverState *bs, int64_t cur_sector, int nr_sectors);
> >   void bdrv_reset_dirty(BlockDriverState *bs, int64_t cur_sector, int 
> > nr_sectors);
> > -void bdrv_dirty_iter_init(BlockDriverState *bs, struct HBitmapIter *hbi);
> > -int64_t bdrv_get_dirty_count(BlockDriverState *bs);
> > +void bdrv_dirty_iter_init(BlockDriverState *bs,
> > +                          BdrvDirtyBitmap *bitmap, struct HBitmapIter *hbi);
> > +int64_t bdrv_get_dirty_count(BlockDriverState *bs, BdrvDirtyBitmap *bitmap);
> >   
> >   void bdrv_enable_copy_on_read(BlockDriverState *bs);
> >   void bdrv_disable_copy_on_read(BlockDriverState *bs);
> You do not really need the BDS argument to the functions, do you?  (Or
> do you have other plans?)

I just wanted to keep the pattern of those bdrv_* family, no other plans 
for it.

Fam