Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default

[Peter Maydell]

On 3 November 2013 16:45, Anthony Liguori <address@hidden> wrote:
> Modern Linux's no longer support /dev/dsp so enabling it by
> default causes audio failures on newer Linux distros.
>
> Signed-off-by: Anthony Liguori <address@hidden>
> ---
>  audio/ossaudio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/audio/ossaudio.c b/audio/ossaudio.c
> index 007c641..3e04a58 100644
> --- a/audio/ossaudio.c
> +++ b/audio/ossaudio.c
> @@ -932,7 +932,7 @@ struct audio_driver oss_audio_driver = {
>      .init           = oss_audio_init,
>      .fini           = oss_audio_fini,
>      .pcm_ops        = &oss_pcm_ops,
> -    .can_be_default = 1,
> +    .can_be_default = 0,
>      .max_voices_out = INT_MAX,
>      .max_voices_in  = INT_MAX,
>      .voice_size_out = sizeof (OSSVoiceOut),

This doesn't look like the right fix for the problem
given in the commit message. If the oss init function
doesn't cleanly return a failure so we can loop round
and try another driver then the init function should
be fixed. If QEMU code itself is printing warnings
then we should silence them. If you're just seeing
warnings from some system audio library (ALSA/pulse/etc)
then either file upstream bugs or just pass configure
the correct audio driver option for your distro.

thanks
-- PMM