qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] kvm: Add a new machine property kvm_type


From: Alexander Graf
Subject: Re: [Qemu-devel] [PATCH] kvm: Add a new machine property kvm_type
Date: Mon, 4 Nov 2013 14:55:36 +0100

On 04.11.2013, at 14:32, Jan Kiszka <address@hidden> wrote:

> On 2013-11-04 14:30, Alexander Graf wrote:
>> 
>> On 04.11.2013, at 14:28, Jan Kiszka <address@hidden> wrote:
>> 
>>> On 2013-10-07 18:53, Aneesh Kumar K.V wrote:
>>>> From: "Aneesh Kumar K.V" <address@hidden>
>>>> 
>>>> Targets like ppc64 support different typed of KVM, one which use
>>>> hypervisor mode and the other which doesn't. Add a new machine
>>>> property kvm_type that helps in selecting the respective ones
>>>> We also add a new QEMUMachine callback get_vm_type that helps
>>>> in mapping the string representation of kvm type specified.
>>>> 
>>>> Signed-off-by: Aneesh Kumar K.V <address@hidden>
>>> 
>>> ...
>>> 
>>>> diff --git a/vl.c b/vl.c
>>>> index 4e709d5..7ecc581 100644
>>>> --- a/vl.c
>>>> +++ b/vl.c
>>>> @@ -427,7 +427,12 @@ static QemuOptsList qemu_machine_opts = {
>>>>            .name = "usb",
>>>>            .type = QEMU_OPT_BOOL,
>>>>            .help = "Set on/off to enable/disable usb",
>>>> +        },{
>>>> +            .name = "kvm_type",
>>>> +            .type = QEMU_OPT_STRING,
>>>> +            .help = "Set to kvm type to be used in create vm ioctl",
>>> 
>>> This does not sound like an appropriate documentation for an enduser.
>>> 
>>> OTOH, I do not recall right now how these help strings can be obtained
>>> at all. One could intuitively try "-machine <sometype>,?", but that's
>>> not implemented. Anyone?
>> 
>> They should definitely show up in the man page. But yes, -machine kvm_type=? 
>> would be helpful as well.
> 
> The man page is not generate from this C code, is it?

No, it has to be part of the patch :).

> 
>> 
>> As for -machine ? we are have a problem orthogonal to this patch. I agree 
>> that we need some way to programmatically list all machine options.
> 
> I'm not saying that this is an issue of this patch, just that I wonder
> how that .help message can be made visisble at at besides with the help
> of an editor.

I think we need both. We also need help on both levels: machine options and 
arguments to machine options.


Alex




reply via email to

[Prev in Thread] Current Thread [Next in Thread]