Re: [Qemu-devel] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss

[Alex Bennée]

address@hidden writes:

> From: Petar Jovanovic <address@hidden>
>
> Creating target_structs header in linux-user/$arch/ and making
> target_ipc_perm and target_shmid_ds its first inhabitants.
> The struct defintions may/should be further fine-tuned by arch maintainers.
>
> Signed-off-by: Petar Jovanovic <address@hidden>
> ---
> v3:
> - add GNU licence to the new header files.
>
> v2:
> - target_struct headers have been created and the patch has been split into
>   two separate patches.
>
>  linux-user/aarch64/target_structs.h    |   58 ++++++++++++++++++++++++
>  linux-user/alpha/target_structs.h      |   48 ++++++++++++++++++++
>  linux-user/arm/target_structs.h        |   52 ++++++++++++++++++++++
>  linux-user/cris/target_structs.h       |   58 ++++++++++++++++++++++++
>  linux-user/i386/target_structs.h       |   58 ++++++++++++++++++++++++
>  linux-user/m68k/target_structs.h       |   58 ++++++++++++++++++++++++
>  linux-user/microblaze/target_structs.h |   58 ++++++++++++++++++++++++
>  linux-user/mips/target_structs.h       |   48 ++++++++++++++++++++
>  linux-user/mips64/target_cpu.h         |   18 ++++++++
>  linux-user/mips64/target_structs.h     |    2 +
>  linux-user/openrisc/target_structs.h   |   58 ++++++++++++++++++++++++
>  linux-user/ppc/target_structs.h        |   60 +++++++++++++++++++++++++
>  linux-user/qemu.h                      |    1 +
>  linux-user/s390x/target_structs.h      |   63 ++++++++++++++++++++++++++
>  linux-user/sh4/target_structs.h        |   58 ++++++++++++++++++++++++
>  linux-user/sparc/target_structs.h      |   63 ++++++++++++++++++++++++++
>  linux-user/sparc64/target_structs.h    |   58 ++++++++++++++++++++++++
>  linux-user/syscall.c                   |   76 
> ++++++++++++--------------------
>  linux-user/unicore32/target_structs.h  |   58 ++++++++++++++++++++++++
>  linux-user/x86_64/target_structs.h     |   58 ++++++++++++++++++++++++
>  20 files changed, 963 insertions(+), 48 deletions(-)
<snip>

There is an awful lot of similarity between a lot of the structures
while not being totally identical. Given the syscall munging is common
is there not an argument for having a common header for this case?

-- 
Alex Bennée