Re: [Qemu-devel] [PATCH v3] net: Adding netmap network backend

[Eric Blake]

On 10/29/2013 04:12 AM, Vincenzo Maffione wrote:
> This patch adds support for a network backend based on netmap.
> netmap is a framework for high speed packet I/O. You can use it
> to build extremely fast traffic generators, monitors, software
> switches or network middleboxes. Its companion software switch
> VALE lets you interconnect virtual machines.
> netmap and VALE are implemented as a non intrusive kernel module,
> support NICs from multiple vendors, are part of standard FreeBSD
> distributions and available in source format for Linux too.
> 

Looking at just the interface:

> +++ b/qapi-schema.json
> @@ -2984,6 +2984,22 @@
>      'hubid':     'int32' } }
>  
>  ##
> +# @NetdevNetmapOptions
> +#
> +# Connect two or more net clients through a VALE switch
> +#
> +# @ifname: optional name of the VALE port
> +#
> +# @devname: optional path of the netmap device

What values are used if I omit these parameters?  It's best to document
what the defaults are (and if you have a hard time choosing sane
defaults, it may be better to make the parameters mandatory).

> +#
> +# Since 1.2

This is wrong; you've already missed 1.7 freeze, so the earliest it can
go in is 1.8.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature