qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/8] Make icount thread-safe


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH 0/8] Make icount thread-safe
Date: Tue, 5 Nov 2013 10:27:32 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, Oct 08, 2013 at 10:47:30AM +0200, Paolo Bonzini wrote:
> This series moves the icount state under the same seqlock as the "normal"
> vm_clock implementation.
> 
> It is not yet 100% thread-safe, because the CPU list should be moved
> under RCU protection (due to the call to !all_cpu_threads_idle()
> in qemu_clock_warp).  However it is a substantial step forward, the
> only uncovered case being CPU hotplug.
> 
> Please review.

Reviewed-by: Stefan Hajnoczi <address@hidden>

Not familiar with the icount code but overall the patches look good and
it comes down to placing a seqlock around icount.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]