[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/7] qdev: unref qdev when device_add fails
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 2/7] qdev: unref qdev when device_add fails |
|
Date: |
Tue, 5 Nov 2013 16:28:49 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Nov 05, 2013 at 04:50:30AM -0700, Eric Blake wrote:
> On 10/30/2013 07:54 AM, Stefan Hajnoczi wrote:
> > qdev_device_add() leaks the created qdev upon failure. I suspect this
> > problem crept in because qdev_free() unparents the qdev but does not
> > drop a reference - confusing name.
>
> Is it worth renaming in a future patch?
Yep, the last patch does that.