Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default

[Gerd Hoffmann]

On Di, 2013-11-05 at 20:34 +0000, Peter Maydell wrote:
> On 5 November 2013 19:57, Anthony Liguori <address@hidden> wrote:
> > This patch just requires that you explicitly select oss so it's not
> > breaking audio on BSD.
> 
> That sounds to me like it's breaking audio for all the
> users for whom it previously worked out of the box
> without any particular configure or command line options.
> In fact I suspect it also breaks audio for all the *linux*
> users for whom it previously worked without special options.

Yes, it does.  Sound is broken by default now.  Only oss is compiled by
default, but it isn't used any more unless you explicitly request that.

My suggestion has it problems too, when adding alsa that way without
having alsa-devel package installed the build breaks.

I think the audio backend handling needs a serious makeover.  Detect
sound libraries (pulse, esd, alsa, ...) via configure like any other
library.  Zap the whole can_be_default logic.  Replace it by walking the
list of backends, sorted by priority, take the first which initializes
successfully.

That is clearly 1.8 material though.  I think for 1.7 we should simply
leave things as-is.  I have a custom --audio-drv-list in my build
scripts for ages, and I suspect all distros and anyone who compiles
itself and cares about audio has.

cheers,
  Gerd