Re: [Qemu-devel] [PATCH v5] net: Adding netmap network backend

[Vincenzo Maffione]

Hi,

  I'm sorry, the v5 patch doesn't fix the strerror(err) bug because I saw your reply on v4 after I sent v5 to fix what was pointed out by Eric Blake.

The v6 patch should hopefully fix also that.

Thanks,

  Vincenzo

2013/11/6 Stefan Hajnoczi <address@hidden>

On Tue, Nov 05, 2013 at 05:42:06PM +0100, Vincenzo Maffione wrote:
> This patch adds support for a network backend based on netmap.
> netmap is a framework for high speed packet I/O. You can use it
> to build extremely fast traffic generators, monitors, software
> switches or network middleboxes. Its companion software switch
> VALE lets you interconnect virtual machines.
> netmap and VALE are implemented as a non-intrusive kernel module,
> support NICs from multiple vendors, are part of standard FreeBSD
> distributions and available in source format for Linux too.
>
> To compile QEMU with netmap support, use the following configure
> options:
>     ./configure [...] --enable-netmap --extra-cflags=-I/path/to/netmap/sys
> where "/path/to/netmap" contains the netmap source code, available at
>     http://info.iet.unipi.it/~luigi/netmap/
>
> The same webpage contains more information about the netmap project
> (together with papers and presentations).
>
> Signed-off-by: Vincenzo Maffione <address@hidden>
> ---

In the future, please include a changelog after the "---" line so
reviewers know what to look for.

I commented on v4, the strerror(error) code looks wrong, it should
probably use the errno variable instead.

Stefan

--
Vincenzo Maffione