[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 37/39] memory: syncronize kvm bitmap using bitmaps o
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH 37/39] memory: syncronize kvm bitmap using bitmaps operations |
Date: |
Wed, 6 Nov 2013 14:04:46 +0100 |
If bitmaps are aligned properly, use bitmap operations. If they are
not, just use old bit at a time code.
Signed-off-by: Juan Quintela <address@hidden>
---
include/exec/memory-physical.h | 54 +++++++++++++++++++++++++++++-------------
1 file changed, 38 insertions(+), 16 deletions(-)
diff --git a/include/exec/memory-physical.h b/include/exec/memory-physical.h
index 72faf06..9057714 100644
--- a/include/exec/memory-physical.h
+++ b/include/exec/memory-physical.h
@@ -82,23 +82,45 @@ static inline void
cpu_physical_memory_set_dirty_lebitmap(unsigned long *bitmap,
ram_addr_t ram_addr;
unsigned int len = (pages + HOST_LONG_BITS - 1) / HOST_LONG_BITS;
unsigned long hpratio = getpagesize() / TARGET_PAGE_SIZE;
+ unsigned long page = BIT_WORD(start >> TARGET_PAGE_BITS);
- /*
- * bitmap-traveling is faster than memory-traveling (for addr...)
- * especially when most of the memory is not dirty.
- */
- for (i = 0; i < len; i++) {
- if (bitmap[i] != 0) {
- c = leul_to_cpu(bitmap[i]);
- do {
- j = ffsl(c) - 1;
- c &= ~(1ul << j);
- page_number = (i * HOST_LONG_BITS + j) * hpratio;
- addr = page_number * TARGET_PAGE_SIZE;
- ram_addr = start + addr;
- cpu_physical_memory_set_dirty_range(ram_addr,
- TARGET_PAGE_SIZE *
hpratio);
- } while (c != 0);
+ /* start address is aligned at the start of a word? */
+ if (((page * BITS_PER_LONG) << TARGET_PAGE_BITS) == start) {
+ int k;
+ int nr = BITS_TO_LONGS(pages);
+
+ printf("XXX: aligned start %lx page %lx\n", start, page);
+ assert(start == ((start >> TARGET_PAGE_BITS) << TARGET_PAGE_BITS));
+
+ for (k = 0; k < nr; k++) {
+ if (bitmap[k]) {
+ unsigned long temp = leul_to_cpu(bitmap[k]);
+
+ ram_list.dirty_memory[DIRTY_MEMORY_MIGRATION][page + k] |=
temp;
+ ram_list.dirty_memory[DIRTY_MEMORY_VGA][page + k] |= temp;
+ ram_list.dirty_memory[DIRTY_MEMORY_CODE][page + k] |= temp;
+ }
+ }
+ xen_modified_memory(start, pages);
+ } else {
+ printf("XXX: not aligned start %lx pages %lu\n", start, pages);
+ /*
+ * bitmap-traveling is faster than memory-traveling (for addr...)
+ * especially when most of the memory is not dirty.
+ */
+ for (i = 0; i < len; i++) {
+ if (bitmap[i] != 0) {
+ c = leul_to_cpu(bitmap[i]);
+ do {
+ j = ffsl(c) - 1;
+ c &= ~(1ul << j);
+ page_number = (i * HOST_LONG_BITS + j) * hpratio;
+ addr = page_number * TARGET_PAGE_SIZE;
+ ram_addr = start + addr;
+ cpu_physical_memory_set_dirty_range(ram_addr,
+ TARGET_PAGE_SIZE *
hpratio);
+ } while (c != 0);
+ }
}
}
}
--
1.8.3.1
- [Qemu-devel] [PATCH 28/39] memory: cpu_physical_memory_clear_dirty_range() now uses bitmap operations, (continued)
- [Qemu-devel] [PATCH 28/39] memory: cpu_physical_memory_clear_dirty_range() now uses bitmap operations, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 30/39] memory: make cpu_physical_memory_reset_dirty() take a length parameter, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 29/39] memory: s/dirty/clean/ in cpu_physical_memory_is_dirty(), Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 32/39] memory: split cpu_physical_memory_* functions to its own include, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 31/39] memory: cpu_physical_memory_set_dirty_tracking() should return void, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 33/39] memory: unfold memory_region_test_and_clear(), Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 34/39] kvm: use directly cpu_physical_memory_* api for tracking dirty pages, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 35/39] kvm: refactor start address calculation, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 37/39] memory: syncronize kvm bitmap using bitmaps operations,
Juan Quintela <=
- [Qemu-devel] [PATCH 36/39] memory: move bitmap synchronization to its own function, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 39/39] migration: synchronize memory bitmap 64bits at a time, Juan Quintela, 2013/11/06
- [Qemu-devel] [PATCH 38/39] ram: split function that synchronizes a range, Juan Quintela, 2013/11/06
- Re: [Qemu-devel] [PATCH v2 00/39] bitmap handling optimization, Gerd Hoffmann, 2013/11/06