|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 37/39] memory: syncronize kvm bitmap using bitmaps operations |
Date: | Wed, 06 Nov 2013 16:58:49 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 06/11/2013 14:04, Juan Quintela ha scritto: > + /* start address is aligned at the start of a word? */ > + if (((page * BITS_PER_LONG) << TARGET_PAGE_BITS) == start) { > + int k; > + int nr = BITS_TO_LONGS(pages); > + > + printf("XXX: aligned start %lx page %lx\n", start, page); > + assert(start == ((start >> TARGET_PAGE_BITS) << TARGET_PAGE_BITS)); This test is useless, since you have already tested the zero-ness of the low bits in the "if" condition: the low bits are 0 in ((page * BITS_PER_LONG) << TARGET_PAGE_BITS). Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |