[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V5 1/6] snapshot: add parameter *errp in snapsho
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH V5 1/6] snapshot: add parameter *errp in snapshot create |
Date: |
Wed, 06 Nov 2013 20:14:17 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 05.11.2013 01:01, Wenchao Xia wrote:
> The return value is only used for error report before this patch,
> so change the function protype to return void.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> block/qcow2-snapshot.c | 30 +++++++++++++++++++++++++-----
> block/qcow2.h | 4 +++-
> block/rbd.c | 19 ++++++++++---------
> block/sheepdog.c | 28 ++++++++++++++++++----------
> block/snapshot.c | 19 +++++++++++++------
> blockdev.c | 10 ++++------
> include/block/block_int.h | 5 +++--
> include/block/snapshot.h | 5 +++--
> qemu-img.c | 10 ++++++----
> savevm.c | 12 ++++++++----
> 10 files changed, 93 insertions(+), 49 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
- [Qemu-devel] [PATCH V5 0/6] qcow2: rollback the modification on fail in snapshot creation, Wenchao Xia, 2013/11/05
- [Qemu-devel] [PATCH V5 3/6] qcow2: do not free clusters when fail in header update in qcow2_write_snapshots, Wenchao Xia, 2013/11/05
- [Qemu-devel] [PATCH V5 6/6] qemu-iotests: add test for qcow2 snapshot, Wenchao Xia, 2013/11/05
- [Qemu-devel] [PATCH V5 4/6] qcow2: cancel the modification on fail in qcow2_snapshot_create(), Wenchao Xia, 2013/11/05
- [Qemu-devel] [PATCH V5 2/6] qcow2: add error message in qcow2_write_snapshots(), Wenchao Xia, 2013/11/05
- [Qemu-devel] [PATCH V5 1/6] snapshot: add parameter *errp in snapshot create, Wenchao Xia, 2013/11/05
- Re: [Qemu-devel] [PATCH V5 1/6] snapshot: add parameter *errp in snapshot create,
Max Reitz <=
- [Qemu-devel] [PATCH V5 5/6] blkdebug: add debug events for snapshot, Wenchao Xia, 2013/11/05