Re: [Qemu-devel] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss

[Petar Jovanovic]

________________________________________
From: Alex Bennée address@hidden
Sent: Tuesday, November 05, 2013 3:46 PM
To: Petar Jovanovic
Cc: Petar Jovanovic; address@hidden; address@hidden; address@hidden; 
address@hidden; address@hidden
Subject: Re: [Qemu-devel] [PATCH v3 1/2] linux-user: create 
target_structsheader to place ipc_perm and shmid_dss

> I've looked back and I can see the point of moving it out of the
> syscall.c into the appropriate linux-user/${foo}/target_structs.h.
> However for the cases where the given structure is identical maybe
> linux-user/${foo}/target_structs.h should do an:
> #include <linux-user/common/ipc_struct.h>

All the architectures that use common most often used defintion of
ipc_perm and shmid_ds already have the correct definition in the file.
If there are any changes in future, they will be arch-specific, so I'd
disagree with the above.

I'd suggest we commit the change as-is now, and if there are future cases
that may need different solution, we can fine-tune it later.

Cheers,
Petar