Re: [Qemu-devel] [PATCHv7 00/17] block: logical block provisioning enhancements

[Paolo Bonzini]

Il 06/11/2013 20:38, Peter Lieven ha scritto:
> 
> Am 06.11.2013 um 14:09 schrieb Paolo Bonzini <address@hidden>:
> 
>> Il 06/11/2013 14:08, Stefan Hajnoczi ha scritto:
>>> Thanks, applied to my block-next tree:
>>> https://github.com/stefanha/qemu/commits/block-next
>>>
>>> This will go into QEMU 1.8.  Since it's a new feature that touches core
>>> block layer code and several block drivers, I can't merge it into
>>> 1.7-rc.
>>
>> Yay!  With these patches I can properly emulate WRITE SAME in the SCSI
>> layer.
> 
> Yes, you can, but only when write same is used to write zeroes. The other
> case is still unhandled or needs emulation.

WRITE SAME with UNMAP is incorrect in the current QEMU code.  Your patch
let me fix it so that the payload can be read back with no change, *and*
sectors are unmapped when possible.

Paolo