qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH for-1.8 16/61] target-i386: Tidy movsl


From: Richard Henderson
Subject: [Qemu-devel] [PATCH for-1.8 16/61] target-i386: Tidy movsl
Date: Thu, 7 Nov 2013 11:04:39 +1000

Always perform a sign-extending load.  In the extremely unlikely
case that we've used an 0x66 prefix, the extension to 64-bits is
unnecessary but not wrong; the store will still examine only 16 bits.

Signed-off-by: Richard Henderson <address@hidden>
---
 target-i386/translate.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/target-i386/translate.c b/target-i386/translate.c
index 31e6d77..0f00fde 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -7740,11 +7740,7 @@ static target_ulong disas_insn(CPUX86State *env, 
DisasContext *s,
                 gen_op_mov_reg_T0(d_ot, reg);
             } else {
                 gen_lea_modrm(env, s, modrm, &reg_addr, &offset_addr);
-                if (d_ot == MO_64) {
-                    gen_op_ld_v(s, MO_32 | MO_SIGN, cpu_T[0], cpu_A0);
-                } else {
-                    gen_op_ld_v(s, MO_32, cpu_T[0], cpu_A0);
-                }
+                gen_op_ld_v(s, MO_32 | MO_SIGN, cpu_T[0], cpu_A0);
                 gen_op_mov_reg_T0(d_ot, reg);
             }
         } else
-- 
1.8.3.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]