Re: [Qemu-devel] [PATCH for-1.7 v2 0/8] fix address space size issue

[Alexander Graf]

On 07.11.2013, at 11:41, Marcel Apfelbaum <address@hidden> wrote:

> A bug reported by Luiz Capitulino let us to find
> several bugs in memory address space setup.
> 
> One issue is that gdb stub can give us arbitrary addresses
> and we'll try to access them.
> Since our lookup ignored high bits in the address,
> we hit a wrong section and got a crash.
> In fact, PCI devices can access arbitrary addresses too,
> so we should just make lookup robust against this case.
> 
> Another issue has to do with size of regions.
> memory API uses UINT64_MAX so say "all 64 bit" but
> some devices mistakenly used INT64_MAX.
> 
> It should not affect most systems in practice as
> everything should be limited by address space size,
> but it's an API misuse that we should not keep around,
> and it will become a problem if a system with 64 bit
> target address hits this path.
> 
> Patch 1 introduces TARGET_PHYS_ADDR_SPACE_MAX that is
>        the max size for memory regions rendered by exec. 
> Patches 2-3 limits the size of memory regions used by exec.c.
> Patch 4 fixes an actual bug.
> The rest of patches make code cleaner and more robust.

ppc bits are:

Acked-by: Alexander Graf <address@hidden>


Alex