Re: [Qemu-devel] [PATCH 0/2] Giving names to graph's BlockDriverState

[Eric Blake]

On 11/07/2013 08:01 AM, Benoît Canet wrote:
> The following series introduce a new file.node-name property in order to be
> able to give a name to each BlockDriverState of the graph.
> 
> It also define "undefined" as a special value for node-name; a value that 
> will be
> used to indicate to the management that it can not manipulate a node because 
> it
> was not named.

Is it necessary to use the actual string "undefined" to mean unnamed, or
can we be careful and use NULL for unnamed, and all other pointers as
the user-provided name?  Either way, we have to special-case code to
check for the sentinel, but a NULL check is faster than a strcmp(), plus
it feels slightly nicer to not consume a value out of the user's namespace.

> 
> After this patchset is merged I would like to take care of presenting the 
> graph
> to the management. (HMP &&/|| QMP)
> 
> Eric: Do you have some ideas on this topic ?

Overall, I'm looking forward to getting this into qemu 1.8; I'm still
waiting to see what else you propose for QMP interfaces.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature