[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qapi-schema: Update description for NewImageMod
From: |
Wenchao Xia |
Subject: |
Re: [Qemu-devel] [PATCH] qapi-schema: Update description for NewImageMode |
Date: |
Fri, 08 Nov 2013 10:48:04 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 |
于 2013/11/8 2:47, Max Reitz 写道:
> If the NewImageMode is "absolute-paths" but no backing file is available
> (e.g., when mirroring a device with an unbacked image), the target image
> will not be backed either. This patch updates the documentation in
> qapi-schema.json accordingly.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> Follow-up to:
> - block/drive-mirror: Check for NULL backing_hd
> ---
> qapi-schema.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 81a375b..dde8e45 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1736,7 +1736,8 @@
> # @existing: QEMU should look for an existing image file.
> #
> # @absolute-paths: QEMU should create a new image with absolute paths
> -# for the backing file.
> +# for the backing file. If there is no backing file available, the new
> +# image will not be backed either.
> #
> # Since: 1.1
> ##
>
It seems 2nd line should start with space, how about:
# @absolute-paths: QEMU should create a new image with absolute paths,
# the new image would usually have a backing file. If
# no backing file available, the new image will not be
# backed either.