[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] block: Allow the user to define "node-name"
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] block: Allow the user to define "node-name" option. |
|
Date: |
Fri, 8 Nov 2013 10:55:27 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 07.11.2013 um 16:01 hat Benoît Canet geschrieben:
> As node-name is a separate name space as device-name we can enable it's
> definition right now: nobody will use it so no harm involved.
>
> Signed-off-by: Benoit Canet <address@hidden>
As Eric already said, we need to update the QAPI schema for the new
field.
We already have an 'id' field for each BlockDriverState, which is
currently used as the device_name on the top level, and forbidden on
other devices. What is our long-term plan with this?
Should 'id' be for every node that must get a BlockBackend on top, and
'node-name' just for any node? We're mixing BDS and BB configuration
here. It may be okay to do that, especially as long as BBs don't have
more than just device_name to be configured, but we should at least be
aware that we're doing it.
Kevin