Re: [Qemu-devel] [PATCH v3] Fix pc migration from qemu <= 1.5

[David Gibson]

On Tue, Nov 05, 2013 at 06:46:27PM -0500, Cole Robinson wrote:
> The following commit introduced a migration incompatibility:
> 
> commit 568f0690fd9aa4d39d84b04c1a5dbb53a915c3fe
> Author: David Gibson <address@hidden>
> Date:   Thu Jun 6 18:48:49 2013 +1000
> 
>     pci: Replace pci_find_domain() with more general pci_root_bus_path()
> 
> The issue is that i440fx savevm idstr went from 0000:00:00.0/I440FX to
> 0000:00.0/I440FX. Unfortunately we are stuck with the breakage for
> 1.6 machine types.
> 
> Add a compat property to maintain the busted idstr for the 1.6 machine
> types, but revert to the old style format for 1.7+, and <= 1.5.
> 
> Tested with migration from qemu 1.5, qemu 1.6, and qemu.git.

Bother.  I did think about migration compatibility for x86, but
obviously not quite hard enough :(.  Sorry, folks.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

pgpRTmQ18wjcm.pgp
Description: PGP signature