[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.7 v2] block: Print its file name if backin
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH for-1.7 v2] block: Print its file name if backing file opening failed |
|
Date: |
Fri, 08 Nov 2013 06:45:34 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 11/07/2013 08:26 PM, Fam Zheng wrote:
> If backing file doesn't exist, the error message is confusing and
> misleading:
>
> $ qemu /tmp/a.qcow2
> qemu: could not open disk image /tmp/a.qcow2: Could not open file: No
> such file or directory
>
> This is not intuitive. It's better to have the missing file's name in
> the error message. With this patch:
>
> $ qemu-io -c 'read 0 512' /tmp/a.qcow2
> qemu-io: can't open device /tmp/a.qcow2: Could not open backing
> file: Could not open '/stor/vm/arch.raw': No such file or directory
> no file open, try 'help open'
>
> Which is a little bit better.
>
> Signed-off-by: Fam Zheng <address@hidden>
>
> ---
> v2: Don't leak local_err (Eric).
Thanks.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature