[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH V6 3/6] qcow2: do not free clusters when fail in hea
From: |
Wenchao Xia |
Subject: |
[Qemu-devel] [PATCH V6 3/6] qcow2: do not free clusters when fail in header update in qcow2_write_snapshots |
Date: |
Mon, 11 Nov 2013 07:56:13 +0800 |
Signed-off-by: Wenchao Xia <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
---
block/qcow2-snapshot.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c
index 6a1d9de..70e329e 100644
--- a/block/qcow2-snapshot.c
+++ b/block/qcow2-snapshot.c
@@ -299,6 +299,14 @@ static int qcow2_write_snapshots(BlockDriverState *bs,
Error **errp)
"Failed in update of image header at %d with size %d",
(int)offsetof(QCowHeader, nb_snapshots),
(int)sizeof(header_data));
+
+ /*
+ * If the snapshot data part has been updated on disk, then the
+ * clusters at snapshot_offset may be used in next snapshot operation.
+ * If we free those clusters in fail path, they may be allocated and
+ * made dirty causing damage, so skip cluster free to be safe.
+ */
+ snapshots_offset = 0;
goto fail;
}
--
1.7.1
- [Qemu-devel] [PATCH V6 0/6] qcow2: rollback the modification on fail in snapshot creation, Wenchao Xia, 2013/11/11
- [Qemu-devel] [PATCH V6 3/6] qcow2: do not free clusters when fail in header update in qcow2_write_snapshots,
Wenchao Xia <=
- [Qemu-devel] [PATCH V6 2/6] qcow2: add error message in qcow2_write_snapshots(), Wenchao Xia, 2013/11/11
- [Qemu-devel] [PATCH V6 6/6] qemu-iotests: add test for qcow2 snapshot, Wenchao Xia, 2013/11/11
- [Qemu-devel] [PATCH V6 1/6] snapshot: add parameter *errp in snapshot create, Wenchao Xia, 2013/11/11
- [Qemu-devel] [PATCH V6 4/6] qcow2: cancel the modification on fail in qcow2_snapshot_create(), Wenchao Xia, 2013/11/11
- [Qemu-devel] [PATCH V6 5/6] blkdebug: add debug events for snapshot, Wenchao Xia, 2013/11/11
- Re: [Qemu-devel] [PATCH V6 0/6] qcow2: rollback the modification on fail in snapshot creation, Wenchao Xia, 2013/11/13
- Re: [Qemu-devel] [PATCH V6 0/6] qcow2: rollback the modification on fail in snapshot creation, Wenchao Xia, 2013/11/27