[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list |
Date: |
Wed, 13 Nov 2013 13:44:33 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 11/13/2013 03:29 AM, Fam Zheng wrote:
> We have multiple dirty bitmaps in BDS now, switch QAPI to allow query
> it (BlockInfo.dirty_bitmaps), and also drop old BlockInfo.dirty.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block.c | 20 ++++++++++++++++++++
> block/qapi.c | 5 +++++
> include/block/block.h | 1 +
> qapi-schema.json | 6 +++---
> 4 files changed, 29 insertions(+), 3 deletions(-)
>
> +++ b/qapi-schema.json
> @@ -948,8 +948,8 @@
> # @tray_open: #optional True if the device has a tray and it is open
> # (only present if removable is true)
> #
> -# @dirty: #optional dirty bitmap information (only present if the dirty
> -# bitmap is enabled)
> +# @dirty-bitmaps: #optional dirty bitmaps information (only present if the
> +# driver has one or more dirty bitmaps)
Worth adding a '(since 1.8)' designator (may have to be in a followup
patch, since Kevin already put it in his staging tree)
Also, we have an odd mix of tray_open and dirty-bitmaps (but that mix
was already there with io-status); more reason that we should eventually
add a patch for treating - and _ as synonyms in QMP keys.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 1/2] block: per caller dirty bitmap, (continued)
- Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list,
Eric Blake <=
Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list, Wenchao Xia, 2013/11/13