qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Don't write .pyc file


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Don't write .pyc files by default (python -B)
Date: Thu, 14 Nov 2013 15:45:13 +0100

On Tue, Aug 27, 2013 at 3:12 PM, Stefan Weil <address@hidden> wrote:
> When a Python script is run, Python normally writes bytecode into a .pyc file.
> QEMU's build process uses several Python scripts which are called from
> configure or make.
>
> The generated .pyc files take disk space without being of much use, because
> those scripts are short, not time critical and only called a few times.
>
> Python's option -B disables writing of .pyc files. QEMU now uses "python -B"
> as default, but it is still possible to choose a different call by passing
> --python=PYTHON to configure.
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>
> It was necessary to change from "$python" to simply $python in the
> Python test. This should not matter: we already have a simple $python
> in configure, and Python wants to be installed in a path without
> spaces.
>
> Stefan
>
>  configure |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 0a55c20..db69327 100755
> --- a/configure
> +++ b/configure
> @@ -568,7 +568,7 @@ fi
>
>  : ${make=${MAKE-make}}
>  : ${install=${INSTALL-install}}
> -: ${python=${PYTHON-python}}
> +: ${python=${PYTHON-python -B}}
>  : ${smbd=${SMBD-/usr/sbin/smbd}}
>
>  # Default objcc to clang if available, otherwise use CC
> @@ -1348,7 +1348,7 @@ fi
>
>  # Note that if the Python conditional here evaluates True we will exit
>  # with status 1 which is a shell 'false' value.
> -if ! "$python" -c 'import sys; sys.exit(sys.version_info < (2,4) or 
> sys.version_info >= (3,))'; then
> +if ! $python -c 'import sys; sys.exit(sys.version_info < (2,4) or 
> sys.version_info >= (3,))'; then
>    error_exit "Cannot use '$python', Python 2.4 or later is required." \
>        "Note that Python 3 or later is not yet supported." \
>        "Use --python=/path/to/python to specify a supported Python."
> --
> 1.7.10.4

This patch breaks ./configure on RHEL 5 and other older distros that
use Python 2.4.

The version test in ./configure fails because the python interpreter
does not accept the -B option:
http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel5/builds/762/steps/configure/logs/stdio

Can you add -B after version detection, if available?  (No .pyc is
generated for statements evaluated on the command-line during version
detection.)

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]