[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-iotests: filter QEMU monitor \r\n
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-iotests: filter QEMU monitor \r\n |
Date: |
Thu, 14 Nov 2013 21:29:10 -0500 |
On Thu, 14 Nov 2013 15:34:06 +0100
Stefan Hajnoczi <address@hidden> wrote:
> SMTP does not preserve newlines. This is normally not a problem if the
> email body uses DOS or UNIX newlines consistently. In 051.out we mix
> UNIX newlines with DOS newlines (since QEMU monitor output uses \r\n).
>
> This patch filters the QEMU monitor output so the golden master file
> uses UNIX newlines exclusively.
>
> The result is that patches touching 051.out will apply cleanly without
> mangling newlines after this commit.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> If you have trouble applying this patch, you can use by git repo:
> git://github.com/stefanha/qemu.git fix-qemu-io-cr
>
> Luiz: CCed you just because I was surprised monitor.c uses \r\n. Perhaps this
> is because terminal or telnet emulation is somehow mixed into the core
> monitor.c code?
Yes, it's telnet support (we allow a telnet client to connect to the
monitor).