Re: [Qemu-devel] [PATCH v2] pc: add 1.8 machine type

[Vlad Yasevich]

On 11/14/2013 05:37 AM, Michael S. Tsirkin wrote:

> -#define PC_Q35_1_7_MACHINE_OPTIONS PC_Q35_MACHINE_OPTIONS
> +#define PC_Q35_1_8_MACHINE_OPTIONS PC_Q35_MACHINE_OPTIONS
> +
> +static QEMUMachine pc_q35_machine_v1_8 = {
> +    PC_Q35_1_8_MACHINE_OPTIONS,
> +    .name = "pc-q35-1.8",
> +    .alias = "q35",
> +    .init = pc_q35_init,
> +};
> +
> +#define PC_Q35_1_7_MACHINE_OPTIONS PC_Q35_1_8_MACHINE_OPTIONS
>
>   static QEMUMachine pc_q35_machine_v1_7 = {
>       PC_Q35_1_7_MACHINE_OPTIONS,
>       .name = "pc-q35-1.7",
>       .alias = "q35",
> -    .init = pc_q35_init,
> +    .init = pc_q35_init_1_7,
>   };
Hi Michael

Shouldn't the '.alias' be removed from the 1.7 machine?

Thanks
-vlad

> -#define PC_Q35_1_6_MACHINE_OPTIONS PC_Q35_MACHINE_OPTIONS
> +#define PC_Q35_1_6_MACHINE_OPTIONS PC_Q35_1_7_MACHINE_OPTIONS
>
>   static QEMUMachine pc_q35_machine_v1_6 = {
>       PC_Q35_1_6_MACHINE_OPTIONS,
> @@ -313,6 +333,7 @@ static QEMUMachine pc_q35_machine_v1_4 = {
>
>   static void pc_q35_machine_init(void)
>   {
> +    qemu_register_machine(&pc_q35_machine_v1_8);
>       qemu_register_machine(&pc_q35_machine_v1_7);
>       qemu_register_machine(&pc_q35_machine_v1_6);
>       qemu_register_machine(&pc_q35_machine_v1_5);