Re: [Qemu-devel] [PATCH v2] qom: Fix memory leak in object_property_set_link()

[Amos Kong]

On Fri, Nov 15, 2013 at 12:09:47PM -0500, Vlad Yasevich wrote:
> Save the result of the call to object_get_cannonical_path()
> so we can free it.
> 
> Signed-off-by: Vlad Yasevich <address@hidden>
> ---
> v1->v2:  Builds and works :)
> 
>  qom/object.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/qom/object.c b/qom/object.c
> index b617f26..fc19cf6 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -838,8 +838,9 @@ char *object_property_get_str(Object *obj, const char 
> *name,
>  void object_property_set_link(Object *obj, Object *value,
>                                const char *name, Error **errp)
>  {
> -    object_property_set_str(obj, object_get_canonical_path(value),
> -                            name, errp);
> +    gchar *path = object_get_canonical_path(value);
> +    object_property_set_str(obj, path, name, errp);
> +    g_free(path);

Reviewed-by: Amos Kong <address@hidden>

>  }
>  
>  Object *object_property_get_link(Object *obj, const char *name,
> -- 
> 1.8.4.2
> 

-- 
                        Amos.