[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] First Patch, Requesting Comments
From: |
Varad Gautam |
Subject: |
[Qemu-devel] First Patch, Requesting Comments |
Date: |
Mon, 18 Nov 2013 19:19:47 +0530 |
Hi! I'm new here, and am working on my first bug. I have posted a patch
for Bug#603872 [1]. It's incomplete right now, but please have a look and
tell me if I'm headed in the right direction. (I don't know if I can send
incomplete patches to the mailing list for suggestions or if I run into
some problems.)
Usecase: `qemu-img convert` with -p now shows the write speed.
I have a few doubts relating to the patch.
1. I'm calculating the speed using the time taken to run the for(;;)
at qemu-img.c:1477. I figured that every time this loop runs, n1
sectors are converted, and so I calculate the write_speed
accordingly. Is this correct?
2. I have changed qemu-progress.c:qemu_progress_print() to take in a
speed parameter, thinking that it would be the best option. Should I
do it some other way instead (maybe write another function to print
just speed)?
Also, what does IO_BUF_SIZE in the same file relate to?
Thanks.
Varad
[1] https://bugs.launchpad.net/qemu/+bug/603872
- [Qemu-devel] First Patch, Requesting Comments ,
Varad Gautam <=
- Re: [Qemu-devel] First Patch, Requesting Comments , Max Filippov, 2013/11/18
- Re: [Qemu-devel] First Patch, Requesting Comments, Varad Gautam, 2013/11/18
- Re: [Qemu-devel] First Patch, Requesting Comments, Andreas Färber, 2013/11/18
- Re: [Qemu-devel] First Patch, Requesting Comments, Eric Blake, 2013/11/18
- Re: [Qemu-devel] First Patch, Requesting Comments, Varad Gautam, 2013/11/18
- Re: [Qemu-devel] First Patch, Requesting Comments, Eric Blake, 2013/11/18