[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/60] AArch64: Add orr instruction emulation
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 14/60] AArch64: Add orr instruction emulation |
|
Date: |
Tue, 19 Nov 2013 05:51:47 +1000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 11/18/2013 11:55 PM, Michael Matz wrote:
>> > I think we need to either explicitly convert the tcg_shift to a
>> > TCGv_i32, or we need to use an open coded version of the rotr_i64 that
>> > inserts at (32 - n) instead of (64 - n)
>> >
>> > What do you think?
> I think converting tcg_shift might eventually lead to better generated
> code (if tcg is optmizing enough, now or in the future, haven't checked).
Agreed.
r~