[Qemu-devel] [for-1.7] hw/i386/acpi-build.c vs glib-2.12

[Richard Henderson]

hw/i386/acpi-build.c:294:5: error: implicit declaration of function
‘g_string_vprintf’ [-Werror=implicit-function-declaration]
     g_string_vprintf(s, format, args);

Introduced in 2.14.


hw/i386/acpi-build.c:427:5: error: implicit declaration of function
‘g_array_get_element_size’ [-Werror=implicit-function-declaration]
     return table->len * g_array_get_element_size(table);

Introduced in 2.22.


Our (self-)documented minimums are

if test "$mingw32" = yes; then
    # g_poll is required in order to integrate with the glib main loop.
    glib_req_ver=2.20
else
    glib_req_ver=2.12
fi


Within unix variants at least, vs(n)printf is likely to be much more portable
than the glib function.  I suspect MinGW has it as well, though I've not 
checked.

As for g_array_get_element_size, aren't all of your tables element size 1?
That's all I can see from acpi_build_tables_init, though I admit to not digging
deeper.



r~