qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-trivial] [PATCH for 1.7] qobject: Fix compiler wa


From: Michael Tokarev
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH for 1.7] qobject: Fix compiler warning (missing gnu_printf format attribute)
Date: Wed, 20 Nov 2013 13:53:53 +0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10

17.11.2013 22:00, Stefan Weil wrote:
> gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra):
> 
>   CC    qobject/qerror.o
> qobject/qerror.c: In function ‘qerror_from_info’:
> qobject/qerror.c:53:5: error:
>  function might be possible candidate for ‘gnu_printf’ format attribute 
> [-Werror=suggest-attribute=format]
>      qerr->err_msg = g_strdup_vprintf(fmt, *va);
>      ^

Thanks, applied to the trivial-patches queue.  Hopefully we found and verified
all invlcations of qerror_from_info() and there really are no "wrong" 
invocations
which will lead to new warnings after this printf attribute addition... ;)

(This function is static so only this file needed to be checked).

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]