[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/8] ui/sdl2 : initial port to SDL 2.0 (v1.2)
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 1/8] ui/sdl2 : initial port to SDL 2.0 (v1.2) |
Date: |
Wed, 20 Nov 2013 11:52:22 +0100 |
On Mi, 2013-11-20 at 15:52 +1000, Dave Airlie wrote:
> From: Dave Airlie <address@hidden>
>
> I've ported the SDL1.2 code over, and rewritten it to use the SDL2 interface.
Looks sane on a quick glance. Didn't look in detail yet. I would have
suggested to put stuff into structs instead of using global variables,
but I see you do that in patch #5. I think you can squash the two into
one.
> The biggest changes were in the input handling, where SDL2 has done a major
> overhaul, and I've had to include a generated translation file to get from
> SDL2 codes back to qemu compatible ones. I'm still not sure how the keyboard
> layout code works in qemu, so there may be further work if someone can point
> me a test case that works with SDL1.2 and doesn't with SDL2.
Can you describe what is has changed from sdl 1.2 -> 2.0?
Ideally qemu wants a scancode which it can feed into keyboard emulation.
How that'll get mapped into keysyms is guests bussiness.
When qemu can't get a scancode it will try to translate the keysym back
to a scancode, using a keymap (this is what the -k switch is for).
cheers,
Gerd
- [Qemu-devel] [RFC] virtio-gpu and sdl2 so far, Dave Airlie, 2013/11/20
- [Qemu-devel] [PATCH 1/8] ui/sdl2 : initial port to SDL 2.0 (v1.2), Dave Airlie, 2013/11/20
- Re: [Qemu-devel] [PATCH 1/8] ui/sdl2 : initial port to SDL 2.0 (v1.2),
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 2/8] console: add state notifiers for ui<->display, Dave Airlie, 2013/11/20
- [Qemu-devel] [PATCH 4/8] console: add ability to wrap a console., Dave Airlie, 2013/11/20
- [Qemu-devel] [PATCH 3/8] console: add information retrival wrappers, Dave Airlie, 2013/11/20
- [Qemu-devel] [PATCH 5/8] sdl2: update for multihead support., Dave Airlie, 2013/11/20
- [Qemu-devel] [PATCH 6/8] virtio-gpu: v0.1 of the virtio based GPU code., Dave Airlie, 2013/11/20
- [Qemu-devel] [PATCH 7/8] virtio-vga: v1, Dave Airlie, 2013/11/20