qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/4] add sunxi machine


From: Li Guang
Subject: Re: [Qemu-devel] [PATCH 0/4] add sunxi machine
Date: Thu, 21 Nov 2013 07:55:07 +0800
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.1.16) Gecko/20120421 Iceape/2.0.11

Hi, Peter

Peter Maydell wrote:
On 20 November 2013 07:53, liguang<address@hidden>  wrote:
this patch-set implemented a device-reduced
machine type for Allwinner's sunxi series SoC,
like sunxi-4i/5i/7i ...
Li Guang (4)
          hw/arm: add new machine type sunxi
          hw/arm/sunxi-soc: add interrupt controller
          hw/arm/sunxi-soc: add sunxi timer
          hw/arm/sunxi-soc: really initialize sunxi machine
Hi. Thanks for this patch set. I see you've put all the code
into one file in hw/arm, but we prefer each device model
to go in its own file in the right subdirectory of hw/. So
you put the interrupt controller under hw/intc/, the
timer under hw/timer/, and only the top level board model
lives under hw/arm. If you could restructure the
patches this way that would be great.

You'll also need to add VMState descriptions to your
devices so they can be migrated.

OK, let me split it into 3 files, and try to add VMstate.

Thanks!





reply via email to

[Prev in Thread] Current Thread [Next in Thread]