Re: [Qemu-devel] [PATCH 7/8] virtio-vga: v1

[Dave Airlie]

On Wed, Nov 20, 2013 at 10:02 PM, Gerd Hoffmann <address@hidden> wrote:
> On Mi, 2013-11-20 at 15:52 +1000, Dave Airlie wrote:
>> From: Dave Airlie <address@hidden>
>>
>> This is a virtio-vga device built on top of the virtio-gpu device.
>
> Ah, I see what you use the wrapping for.  Hmm.  I think you should use a
> common base class instead, i.e. something like virtio-gpu-base which
> holds all the common stuff.  Both virtio-gpu and virtio-vga can use that
> as TypeInfo->parent then.  This way virtio-vga doesn't have to muck with
> virtio-gpu internals.  virtio-gpu-base can be tagged as abstract class
> (using .abstract = true) so it will not be instantiated directly.
>

I'm not sure what that buys me here, I need the virtio-vga to attach
the vga ops the first console that the virtio-gpu registers, it can't
be a separate console, and since virtio-gpu initialises before
virtio-vga I can't tell it to not register the console.

Its no use attaching just the vga or just the gpu ops to the console I
need a wrapper and I can't see how having a common base class would
help. I already have a base class, that pci subclasses then vga
subclasses that.

Dave.