qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 5/6] qemu-iotests: Force qcow2 in error path


From: Fam Zheng
Subject: Re: [Qemu-devel] [PATCH v3 5/6] qemu-iotests: Force qcow2 in error path test in 048
Date: Thu, 21 Nov 2013 20:50:23 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1

On 2013年11月21日 20:41, Stefan Hajnoczi wrote:
On Wed, Nov 20, 2013 at 03:44:16PM +0800, Fam Zheng wrote:
The "raw" doesn't always work on certain file systems (e.g. tmpfs). Use
qcow2 to make the allocation status explicit.

Signed-off-by: Fam Zheng <address@hidden>
---
  tests/qemu-iotests/048 | 8 +++++++-
  1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/048 b/tests/qemu-iotests/048
index 9def7fc..0fb5d2c 100755
--- a/tests/qemu-iotests/048
+++ b/tests/qemu-iotests/048
@@ -88,7 +88,13 @@ event = "read_aio"
  errno = "5"
  once ="off"
  EOF
-_make_test_img $size
+if [ "$IMGFMT" = "raw" ]; then
+    # For raw the allocation status for new image depends on file system, force
+    # qcow2 in this case, since the tested code is in block layer
+    IMGFMT=qcow2 _make_test_img $size | _filter_imgfmt

If it can't be tested, skip the test.  Don't silently test something
else.


OK. Do you think I should split the test? Since we don't have conditional reference output.

Fam




reply via email to

[Prev in Thread] Current Thread [Next in Thread]