Re: [Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE

[Igor Mammedov]

On Thu, 21 Nov 2013 16:28:40 +0800
Hu Tao <address@hidden> wrote:

> On Thu, Nov 21, 2013 at 10:26:36AM +0200, Michael S. Tsirkin wrote:
> > On Thu, Nov 21, 2013 at 04:12:22PM +0800, Hu Tao wrote:
> > > On Thu, Nov 21, 2013 at 09:14:18AM +0200, Michael S. Tsirkin wrote:
> > > > On Thu, Nov 21, 2013 at 03:38:37AM +0100, Igor Mammedov wrote:
> > > > > it fixes IRQ storm since guest isn't able to lower SCI IRQ
> > > > > after it has been handled when it clears GPE event.
> > > > > 
> > > > > Signed-off-by: Igor Mammedov <address@hidden>
> > > > 
> > > > The storm is only on memory hotplug right?
> > > 
> > > IIRC, it happens on cpu hotplug, too.
> > 
> > So this is a bugfix then? We should include this in 1.7?
> 
> Yes. but cpu hotplug support is not added for q35, so the bug doesn't
> affect anyone, yet.
> 

I was thinking about CPU hotplug for q35 as well, thus patch

1/27 "acpi: factor out common pm_update_sci() into acpi core"

moves common for CPU/Memory hotplug ACPI bits into generic code,
so making CPU hotplug for q35 would require only unifying CPU
hotplug bits and plumbing it in q35 its done for mem hotplug in:

 [PATCH 17/27] acpi: initialize memory hotplug ACPI ICH9 hardware