Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

[Andreas Färber]

Am 21.11.2013 06:48, schrieb Li Guang:
> Hi, Igor
> 
> Igor Mammedov wrote:
>> Add DimmBus for memory hotplug below 4Gb or above 4Gb depending
>> on initial memory size and hotplug memory size.
>>    
> ...
>> +static
>> +void pc_hotplug_memory_init_impl(Object *owner,
>> +                                 MemoryRegion *system_memory,
>> +                                 ram_addr_t low_hotplug_mem_start,
>> +                                 ram_addr_t low_hotplug_mem_end,
>> +                                 DimmBus *hotplug_mem_bus,
>> +                                 ram_addr_t *high_mem_end)
>> +{
>> +    QemuOpts *opts = qemu_opts_find(qemu_find_opts("memory-opts"),
>> NULL);
>> +    ram_addr_t ram_size = qemu_opt_get_size(opts, "mem", 0);
>> +    ram_addr_t maxmem = qemu_opt_get_size(opts, "maxmem", 0);
>> +    ram_addr_t hotplug_mem_size;
>> +
>> +    if (maxmem<= ram_size) {
>> +        /* Disable ACPI migration code and creation of memory devices
>> in SSDT */
>>    
> 
> Why not give the memory that not be hot-added a chance to be placed on
> one memory slot?

Seconded, I believe I requested that on the previous version already.

Andreas

> if all memory can be hot-added and hot-removed, then we can bring in
> more flexibility for
> memory hotplug feature.

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg