Re: [Qemu-devel] [PATCH v6 0/4] Use blkdebug to make test deterministic

[Stefan Hajnoczi]

On Wed, Nov 20, 2013 at 10:01:52AM +0800, Fam Zheng wrote:
> This adds "remove_break" command to block, which removes a break point defined
> with "break". It is used in iotests.py to pause and resume drive in block job
> cases to make the test deterministic.
> 
> v6: [04] Fix 055 race condition by keeping sleep after resume_drive. (Stefan)
> 
> v5: Addressing Max's comments (thanks for reviewing)
>     [02] Resume all the requests.
>     [03] Fix event="" case. Change default value to None.
>          Change resume to bool.
>     [04] Change resume to bool
> 
> v4: [01] Added.
>     [03] Add common method pair "pause_drive" and "resume_drive".
>     [04] Also fix 040, 055.
> 
> 
> Fam Zheng (4):
>   qemu-iotests: Drop local version of cancel_and_wait from 040
>   blkdebug: add "remove_break" command
>   qemu-iotest: Add pause_drive and resume_drive methods
>   qemu-iotests: Make test case 030, 040 and 055 deterministic
> 
>  block.c                       | 13 +++++++++++++
>  block/blkdebug.c              | 27 +++++++++++++++++++++++++++
>  include/block/block.h         |  1 +
>  include/block/block_int.h     |  2 ++
>  qemu-io-cmds.c                | 22 ++++++++++++++++++++++
>  tests/qemu-iotests/030        | 16 +++++++++++-----
>  tests/qemu-iotests/040        | 19 +++----------------
>  tests/qemu-iotests/055        | 14 +++++++++++---
>  tests/qemu-iotests/iotests.py | 18 +++++++++++++++++-
>  9 files changed, 107 insertions(+), 25 deletions(-)

I ran 055 successfully 6 times in a row, the issue seems to be gone.

Thanks, applied to my block-next tree:
https://github.com/stefanha/qemu/commits/block-next

Stefan