Re: [Qemu-devel] [PATCH] qdev-properties-system.c: Allow vlan or netdev for -device, not both

[Stefan Hajnoczi]

On Thu, Nov 07, 2013 at 09:13:09PM -0500, Vlad Yasevich wrote:
> It is currently possible to specify things like:
>       -device e1000,netdev=foo,vlan=1
> With this usage, whichever argument was specified last (vlan or netdev)
> overwrites what was previousely set and results in a non-working
> configuration.  Even worse, when used with multiqueue devices,
> it causes a segmentation fault on exit in qemu_free_net_client.
> 
> That patch treates the above command line options as invalid and
> generates an error at start-up.
> 
> Signed-off-by: Vlad Yasevich <address@hidden>
> ---
>  hw/core/qdev-properties-system.c | 9 +++++++++
>  1 file changed, 9 insertions(+)

Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net

Stefan