Re: [Qemu-devel] [RFC PATCH 6/8] cpu: Add per-cpu address space

[Edgar E. Iglesias]

Hi, no I actually had it in cpustate first but had to do env-get-cpu all over so i moved it to env. Iiuc env-get-cpu involves a dyn typecheck. I havent meassured the perf impact though.

Sorry for phone email...

Cheers

---
Sent from my phone

On Nov 22, 2013 4:51 PM, "Peter Maydell" <address@hidden> wrote:

On 22 November 2013 15:15,  <address@hidden> wrote:
> @@ -176,6 +176,9 @@ typedef struct CPUWatchpoint {
>      sigjmp_buf jmp_env;                                                 \
>      int exception_index;                                                \
>                                                                          \
> +    /* Per CPU address-space.  */                                       \
> +    AddressSpace *as;                                                   \
> +                                                                        \

Does this really have to live in the env struct rather than
CPUState ?

thanks
-- PMM