Re: [Qemu-devel] [PATCH v3 1/4] hw/timer: add sunxi timer device

[Peter Maydell]

On 25 November 2013 10:15, Peter Crosthwaite
<address@hidden> wrote:
> Hi,
>
> On Mon, Nov 25, 2013 at 5:41 PM, liguang <address@hidden> wrote:
>> +#define SUNXI_TIMER_IRQ_EN 0
>> +#define SUNXI_TIMER_IRQ_ST 0x4
>> +#define SUNXI_TIMER_CONTROL 0x0
>> +#define SUNXI_TIMER_INTERVAL 0x4
>> +#define SUNXI_TIMER_COUNT 0x8
>> +#define SUNXI_WDOG_CONTROL 0x90
>> +#define SUNXI_WDOG_MODE 0x94
>> +#define SUNXI_COUNT_CTL 0xa0
>> +#define SUNXI_COUNT_LO 0xa4
>> +#define SUNXI_COUNT_HI 0xa8
>> +#define SUNXI_TIMER_BASE 0x10
>> +
>
> You could tab out the numbers to a consistent tab-stop for easier reading.

...but use spaces, not tab characters, please.

thanks
-- PMM