Re: [Qemu-devel] [PATCH 23/27] pc: ACPI BIOS: implement memory hotplug interface

[Paolo Bonzini]

Il 21/11/2013 03:38, Igor Mammedov ha scritto:
> +                // 64-bit math: MAX = MIN + LEN - 1
> +                Add(MINL, LENL, MAXL)
> +                Add(MINH, LENH, MAXH)
> +                If (Or(LLess(MAXL, MINL), LLess(MAXL, LENL))) {

The Or is not necessary, LLess(MAXL, MINL) is enough.

> +                    Add(MAXH, 1, MAXH)

One?  (Just for consistency, iasl does it already).

> +                }

> +                // Ignore (MAXL == 0 & MAXH == 0) case
> +                If (LEqual(MAXL, Zero)) {
> +                    Subtract(MAXH, One, MAXH)
> +                    Store(0xFFFFFFFF, MAXL)
> +                } Else {
> +                    Subtract(MAXL, One, MAXL)
> +                }
> +

Why not this:

                   If (LLess(MAXL, One)) {
                       Subtract(MAXH, One, MAXH)
                   }
                   Subtract(MAXL, One, MAXL)

Paolo