[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1.8 6/6] qemu-img: add option to show progress in se
From: |
Peter Lieven |
Subject: |
[Qemu-devel] [PATCH 1.8 6/6] qemu-img: add option to show progress in sectors |
Date: |
Mon, 25 Nov 2013 14:57:20 +0100 |
Signed-off-by: Peter Lieven <address@hidden>
---
qemu-img-cmds.hx | 4 ++--
qemu-img.c | 23 ++++++++++++++++++++---
2 files changed, 22 insertions(+), 5 deletions(-)
diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx
index 266cdf3..4190ec1 100644
--- a/qemu-img-cmds.hx
+++ b/qemu-img-cmds.hx
@@ -34,9 +34,9 @@ STEXI
ETEXI
DEF("convert", img_convert,
- "convert [-c] [-p] [-q] [-n] [-a] [-f fmt] [-t cache] [-O output_fmt] [-o
options] [-s snapshot_name] [-S sparse_size] [-m iobuf_size] filename
[filename2 [...]] output_filename")
+ "convert [-c] [-p|pp] [-q] [-n] [-a] [-f fmt] [-t cache] [-O output_fmt]
[-o options] [-s snapshot_name] [-S sparse_size] [-m iobuf_size] filename
[filename2 [...]] output_filename")
STEXI
address@hidden convert [-c] [-p] [-q] [-n] [-a] [-f @var{fmt}] [-t @var{cache}]
[-O @var{output_fmt}] [-o @var{options}] [-s @var{snapshot_name}] [-S
@var{sparse_size}] [-m @var{iobuf_size}] @var{filename} address@hidden [...]]
@var{output_filename}
address@hidden convert [-c] [-p|pp] [-q] [-n] [-a] [-f @var{fmt}] [-t
@var{cache}] [-O @var{output_fmt}] [-o @var{options}] [-s @var{snapshot_name}]
[-S @var{sparse_size}] [-m @var{iobuf_size}] @var{filename} address@hidden
[...]] @var{output_filename}
ETEXI
DEF("info", img_info,
diff --git a/qemu-img.c b/qemu-img.c
index 9fa8fd4..f58247f 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -99,6 +99,7 @@ static void help(void)
" rebasing in this case (useful for renaming the backing
file)\n"
" '-h' with or without a command shows this help and lists the
supported formats\n"
" '-p' show progress of command (only certain commands)\n"
+ " '-pp' show progress of command in sectors (only convert
command)\n"
" '-q' use Quiet mode - do not print any output (except errors)\n"
" '-S' indicates the consecutive number of bytes (defaults to 4k)
that must\n"
" contain only zeros for qemu-img to create a sparse image
during\n"
@@ -1124,6 +1125,14 @@ out3:
return ret;
}
+static void print_sector_progress(int progress, int64_t sector_num,
+ int64_t total_sectors)
+{
+ if (progress == 2) {
+ printf("%ld of %ld sectors converted.\r", sector_num, total_sectors);
+ }
+}
+
static int img_convert(int argc, char **argv)
{
int c, n, n1, bs_n, bs_i, compress, cluster_sectors, skip_create;
@@ -1132,7 +1141,7 @@ static int img_convert(int argc, char **argv)
const char *fmt, *out_fmt, *cache, *out_baseimg, *out_filename;
BlockDriver *drv, *proto_drv;
BlockDriverState **bs = NULL, *out_bs = NULL;
- int64_t total_sectors, nb_sectors, sector_num, bs_offset,
+ int64_t total_sectors = 0, nb_sectors, sector_num, bs_offset,
sector_num_next_status = 0;
uint64_t bs_sectors;
uint8_t * buf = NULL;
@@ -1219,7 +1228,7 @@ static int img_convert(int argc, char **argv)
break;
}
case 'p':
- progress = 1;
+ progress++;
break;
case 't':
cache = optarg;
@@ -1245,7 +1254,7 @@ static int img_convert(int argc, char **argv)
out_filename = argv[argc - 1];
/* Initialize before goto out */
- qemu_progress_init(progress, 2.0);
+ qemu_progress_init(progress == 1, 2.0);
if (options && is_help_option(options)) {
ret = print_block_option_help(out_filename, out_fmt);
@@ -1276,6 +1285,8 @@ static int img_convert(int argc, char **argv)
total_sectors += bs_sectors;
}
+ print_sector_progress(progress, 0, total_sectors);
+
if (snapshot_name != NULL) {
if (bs_n > 1) {
error_report("No support for concatenating multiple snapshot");
@@ -1481,6 +1492,7 @@ static int img_convert(int argc, char **argv)
}
sector_num += n;
qemu_progress_print(100.0 * sector_num / total_sectors, 0);
+ print_sector_progress(progress, sector_num, total_sectors);
}
/* signal EOF to align */
bdrv_write_compressed(out_bs, 0, NULL, 0);
@@ -1595,11 +1607,16 @@ static int img_convert(int argc, char **argv)
buf1 += n1 * 512;
}
qemu_progress_print(100.0 * sector_num / total_sectors, 0);
+ print_sector_progress(progress, sector_num, total_sectors);
}
}
out:
if (!ret) {
qemu_progress_print(100, 0);
+ print_sector_progress(progress, total_sectors, total_sectors);
+ }
+ if (progress == 2) {
+ printf("\n");
}
qemu_progress_end();
free_option_parameters(create_options);
--
1.7.9.5
- Re: [Qemu-devel] [PATCH 1.8 3/6] qemu-img: add option to specify alternate iobuffer size, (continued)
[Qemu-devel] [PATCH 1.8 2/6] qemu-img: fix usage instruction for qemu-img convert, Peter Lieven, 2013/11/25
[Qemu-devel] [PATCH 1.8 1/6] qemu-img: add support for skipping zeroes in input during convert, Peter Lieven, 2013/11/25
[Qemu-devel] [PATCH 1.8 4/6] block/iscsi: set bdi->cluster_size, Peter Lieven, 2013/11/25
[Qemu-devel] [PATCH 1.8 6/6] qemu-img: add option to show progress in sectors,
Peter Lieven <=
[Qemu-devel] [PATCH 1.8 5/6] qemu-img: add option to align writes to cluster_sectors during convert, Peter Lieven, 2013/11/25
Re: [Qemu-devel] [PATCH 1.8 5/6] qemu-img: add option to align writes to cluster_sectors during convert, Peter Lieven, 2013/11/25
Re: [Qemu-devel] [PATCH 1.8 5/6] qemu-img: add option to align writes to cluster_sectors during convert, Paolo Bonzini, 2013/11/25