qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 3/7] block: Replace in_use with operation blo


From: Fam Zheng
Subject: Re: [Qemu-devel] [PATCH v4 3/7] block: Replace in_use with operation blocker
Date: Tue, 26 Nov 2013 10:18:14 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1

On 2013年11月26日 01:11, Paolo Bonzini wrote:
Il 22/11/2013 06:24, Fam Zheng ha scritto:
@@ -41,13 +41,11 @@ void *block_job_create(const BlockJobDriver *driver, 
BlockDriverState *bs,
  {
      BlockJob *job;

-    if (bs->job || bdrv_in_use(bs)) {
+    if (bs->job) {
          error_set(errp, QERR_DEVICE_IN_USE, bdrv_get_device_name(bs));
          return NULL;
      }
      bdrv_ref(bs);

Why is this check disappearing?


Because this patch is moving this check to callers, and changing it to op blocker check.

Fam



reply via email to

[Prev in Thread] Current Thread [Next in Thread]