[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 29/60] AArch64: Add orri instruction emulation
From: |
Claudio Fontana |
Subject: |
Re: [Qemu-devel] [PATCH 29/60] AArch64: Add orri instruction emulation |
Date: |
Tue, 26 Nov 2013 12:56:35 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120909 Thunderbird/15.0.1 |
On 09/27/2013 09:42 PM, Richard Henderson wrote:
> On 09/26/2013 05:48 PM, Alexander Graf wrote:
>> + if (setflags) {
>> + tcg_dst = cpu_reg(dest);
>> + } else {
>> + tcg_dst = cpu_reg_sp(dest);
>> + }
>
> Never sp for logicals.
This should be ok in my view, the manual explicitly shows in the pseudocode:
if d == 31 && !setflags then
SP[] = result;
else
X[d] = result;
Claudio
>
>> + handle_orri(s, insn);
>
> And yet again, a better function name.
>
>
> r~
>
- Re: [Qemu-devel] [PATCH 29/60] AArch64: Add orri instruction emulation,
Claudio Fontana <=