Re: [Qemu-devel] [PATCH rebased for-1.8] i386: pc: align gpa<->hpa on 1GB boundary (v6)

[Marcelo Tosatti]

On Mon, Nov 25, 2013 at 11:05:10PM +0200, Michael S. Tsirkin wrote:
> On Mon, Nov 25, 2013 at 06:43:13PM +0100, Paolo Bonzini wrote:
> > v2: condition enablement of new mapping to new machine types (Paolo)
> > v3: fix changelog
> > v4: rebase
> > v5: ensure alignment of piecetwo on 2MB GPA (Igor)
> >     do not register zero-sized piece-one    (Igor)
> > v6: fix memory leak                         (Igor)
> >     fix integer overflow                    (Igor)
> > 
> > ----
> > 
> > Align guest physical address and host physical address
> > beyond guest 4GB on a 1GB boundary.
> > 
> > Otherwise 1GB TLBs cannot be cached for the range.
> > 
> > Signed-off-by: Marcelo Tosatti <address@hidden>
> > [Reorganize code, keep same logic. - Paolo]
> > Signed-off-by: Paolo Bonzini <address@hidden>
> 
> BTW how about a unit-test for this?
> Can be something along the lines of the acpi tests:
> run BIOS, probe what it reported.

There is no guest visible difference.